-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --force
argument to the stop
command
#1946
Conversation
Hey @luis4a0, I know this is still in draft, but I always envisioned just adding a |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1946 +/- ##
==========================================
+ Coverage 88.83% 88.89% +0.05%
==========================================
Files 253 254 +1
Lines 14170 14222 +52
==========================================
+ Hits 12588 12642 +54
+ Misses 1582 1580 -2 ☔ View full report in Codecov by Sentry. |
Hey @townsend2010, thanks a lot for your comment! What you propose makes complete sense, I'll finish testing if the commands I used indeed work to turn off VM's and then rework the code. |
1f21eac
to
3a7b09d
Compare
36d6cec
to
a4f04ff
Compare
b10bc1a
to
69ebeca
Compare
Once this is in, I think we should also change |
65903a3
to
708bd3a
Compare
41f273e
to
b1a5b88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @townsend2010, thanks for the PR! Not a proper review, but I was looking in order to base my work on top, so leaving a couple of comments.
4be3838
to
8ac8d93
Compare
8ac8d93
to
45dcacd
Compare
45dcacd
to
1861b89
Compare
…o using condition variable wait where is no other thread notifies him. This fix the non-responding bug on qemu force stop.
…nce the state variable is the only one needs to be protected, also convert unique_lock to scoped_lock because manual unlock/ lock is no longer needed.
…iable during the previous refactor commit.
…eck_state_for_shutdown function since the state variable is the only one needs to be protected, also convert unique_lock to scoped_lock because manual unlock/ lock is no longer needed."
…e use vm_process->wait_for_finished to sync
…n boolean of wait_for_finished and log correspondingly.
Co-authored-by: Ricardo Abreu <[email protected]> Signed-off-by: George Liao <[email protected]>
31757e4
to
5173700
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, everything seems to be working. Thanks, @georgeliao!
Add `--force` argument to the `stop` command
@ricab we might need to manually merge again. |
Add `--force` argument to the `stop` command
Add `--force` argument to the `stop` command
Add a new parameter to force the shutdown instances (i.e., power down them).
Fixes #1909, Fixes #2492